Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run for specific target #374

Merged
merged 5 commits into from
May 9, 2023
Merged

Run for specific target #374

merged 5 commits into from
May 9, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented May 2, 2023 •
edited

This allows to run build for a specific stack by doit build --target base --target base-with-services. Otherwise, all stacks are builded and takes time during developing.

@unkcpz unkcpz requested review from danielhollas and removed request for danielhollas May 8, 2023 15:05
@unkcpz
Copy link
Member Author

unkcpz commented May 8, 2023

The installation failed everywhere because of pybtex which I guess from pymatgen as well. But it seems they pinned it to 0.24 that is a version should work. Inside the container it tried to install pybtex=0.22 and cause the problem.

@danielhollas
Copy link
Contributor

The installation failed everywhere because of pybtex which I guess from pymatgen as well. But it seems they pinned it to 0.24 that is a version should work. Inside the container it tried to install pybtex=0.22 and cause the problem.

Not sure I understand. Is pybtex dependency coming from pymatgen? So this needs a fix in the QeApp and not in the Docker image?

danielhollas
danielhollas reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never used doit or bake for local development so I am not the best for review. It looks fine at a glance, but I do not understand whether this PR depends on #372 or not.

dodo.py Show resolved Hide resolved
@unkcpz unkcpz mentioned this pull request May 8, 2023
Merged
@unkcpz
Copy link
Member Author

unkcpz commented May 8, 2023

@danielhollas thanks for the review. I think there is nothing specific that requires a close look, this simply makes the target option work, if it works, it works 🤷

@danielhollas danielhollas self-requested a review May 8, 2023 20:29
@unkcpz unkcpz merged commit 5a1de2e into main May 9, 2023
@unkcpz unkcpz deleted the run-for-specific-target branch May 9, 2023 09:44
@unkcpz
Copy link
Member Author

unkcpz commented May 9, 2023

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhollas danielhollas danielhollas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@unkcpz @danielhollas