bump AWB to released 2.0 #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
bump-awb-2.0
branch
4 times, most recently
from
d492323
to
f1e9bef
Compare
unkcpz
commented
May 8, 2023
| widget-bandsplot~=0.5.1 | ||
| pybtex==0.24.0 |
There was a problem hiding this comment.
This somehow has to be pinned, because of the issue https://github.com/aiidalab/aiidalab-qe/actions/runs/4917462707/jobs/8782576404. It also fails the test of aiidalab-docker-stack in aiidalab/aiidalab-docker-stack#374
superstar54
requested changes
May 9, 2023
| @@ -22,13 +22,12 @@ project_urls = | |||
| [options] | |||
| packages = find: | |||
| install_requires = | |||
| Jinja2~=3.0 | |||
There was a problem hiding this comment.
Please keep jinjia2 and importlib-resources here. Otherwise, the dependency is not clear.
There was a problem hiding this comment.
Yes, make sense. I delete it for test. You are correct, since it is used in the package, better to keep in the dependencies list.
There was a problem hiding this comment.
But I loose the version a bit so it more flexible to the change from upstream packages, e.g aiida-core and aiida-quantumespresso.
superstar54
approved these changes
May 9, 2023
unkcpz
added a commit
that referenced
this pull request
May 9, 2023
`aiidalab-widgets-base` 2.0 is released, the version is bump here. Jinja2 and importlib are from aiida-quantumespresso, therefore the version is loosely pinned. The pybtex has to be added to work around the installation issue.
unkcpz
added a commit
that referenced
this pull request
May 9, 2023
unkcpz
added a commit
that referenced
this pull request
May 9, 2023
`aiidalab-widgets-base` 2.0 is released, the version is bump here. Jinja2 and importlib are from aiida-quantumespresso, therefore the version is loosely pinned. The pybtex has to be added to work around the installation issue.
unkcpz
added a commit
that referenced
this pull request
May 9, 2023
`aiidalab-widgets-base` 2.0 is released, the version is bump here. Jinja2 and importlib are from aiida-quantumespresso, therefore the version is loosely pinned. The pybtex has to be added to work around the installation issue.
unkcpz
added a commit
that referenced
this pull request
May 17, 2023
workaround r-andres bump AWB to released 2.0 (#394) `aiidalab-widgets-base` 2.0 is released, the version is bump here. Jinja2 and importlib are from aiida-quantumespresso, therefore the version is loosely pinned. The pybtex has to be added to work around the installation issue. Move module imports from __init__.py of package to app modules (#393) Remove report legacy support pinning qe plugin so test pass
unkcpz
added a commit
that referenced
this pull request
May 17, 2023
workaround r-andres bump AWB to released 2.0 (#394) `aiidalab-widgets-base` 2.0 is released, the version is bump here. Jinja2 and importlib are from aiida-quantumespresso, therefore the version is loosely pinned. The pybtex has to be added to work around the installation issue. Move module imports from __init__.py of package to app modules (#393) Remove report legacy support pinning qe plugin so test pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja2 and importlib are from aiida-quantumespresso, therefore the version is loosely pinned. The pybtex has to be added to work around the installation issue.