Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump AWB to released 2.0 #394

Merged
merged 3 commits into from
May 9, 2023
Merged

bump AWB to released 2.0 #394

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
024feb3
bump AWB to released 2.0
unkcpz May 8, 2023
292af39
test: issue from pymatgen?
unkcpz May 8, 2023
9dfdaa9
r-xw
unkcpz May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@ project_urls =
[options]
packages = find:
install_requires =
Jinja2~=3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep jinjia2 and importlib-resources here. Otherwise, the dependency is not clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, make sense. I delete it for test. You are correct, since it is used in the package, better to keep in the dependencies list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I loose the version a bit so it more flexible to the change from upstream packages, e.g aiida-core and aiida-quantumespresso.

aiida-core~=2.2,<3
aiida-quantumespresso~=4.2
aiidalab-widgets-base==2.0.0b6
aiidalab-widgets-base~=2.0
filelock~=3.8
importlib-resources~=5.2.2
widget-bandsplot~=0.5.1
pybtex==0.24.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This somehow has to be pinned, because of the issue https://github.com/aiidalab/aiidalab-qe/actions/runs/4917462707/jobs/8782576404. It also fails the test of aiidalab-docker-stack in aiidalab/aiidalab-docker-stack#374

pymatgen==2022.9.21
python_requires = >=3.8

Expand Down