Remove aiidalab-widgets-base from app store #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should wait with this until AWB is in the base image, to be on the safe side. Also I believe there is some functionality in that @yakutovicha wants to migrate to aiidalab-home? |
Why? I didn't see the potential problem. If the app need AWB then it is in the dependencies of the app. |
|
Do we know what happens to existing installations, that were installed via
the registry and then the App is removed from registry?
Dne st 21. 2. 2024 14:32 uživatel Jusong Yu ***@***.***>
napsal:
… I think we should wait with this until AWB is in the base image, to be on
the safe side.
Why? I didn't see the potential problem. If the app need AWB then it is in
the dependencies of the app.
—
Reply to this email directly, view it on GitHub
<#133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIY64OPBP3KJULVEP6QS63YUYAOVAVCNFSM6AAAAABDTERSCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWG44DCMZYHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Emm... this is a good point. But how to test it? |
|
I am not sure since I am not that familiar with the registry. But this
doesn't feel like a pressing PR right now since it is not blocking anything.
Dne st 21. 2. 2024 15:23 uživatel Jusong Yu ***@***.***>
napsal:
… Emm... this is a good point. But how we test it?
—
Reply to this email directly, view it on GitHub
<#133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIY64IXYYITL4EXUGBDWFDYUYGPJAVCNFSM6AAAAABDTERSCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWHEZTCOJRGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Yes, indeed, I need to migrate those notebooks to the aiidalab-home app first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards aiidalab/aiidalab-widgets-base#552