Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support different model styles for the structure, e.g. Sphere, Ball-and-Stick #366

Closed
Tracked by #363
cpignedoli opened this issue Oct 14, 2022 · 3 comments · Fixed by #373
Closed
Tracked by #363

support different model styles for the structure, e.g. Sphere, Ball-and-Stick #366

cpignedoli opened this issue Oct 14, 2022 · 3 comments · Fixed by #373
Assignees
Milestone

Comments

@cpignedoli
Copy link
Member

cpignedoli commented Oct 14, 2022

I am working on it migrating what we did for the empa_viewer, I will need the help of @yakutovicha to finalize it

@superstar54
Copy link
Member

Thanks for implementing this. Please assign me as a reviewer when done. I am interested in it.

@danielhollas
Copy link
Contributor

@cpignedoli would you mind tagging me for review as well? I am interested specifically in the render performance of your solution. In the current code, the style is reapplied upon each render, which makes it very janky when quickly switching between structures (in my case I am working on the TrajectoryViewer, where this is critical). Thanks!

@cpignedoli
Copy link
Member Author

more than happy to have you all @superstar54 @danielhollas on board :) but I can anticipate that what was in empa_viewer was not really performant
https://github.com/nanotech-empa/aiidalab-empa-surfaces/blob/318670658e7e7d090e9c84dac53626bca8b9a638/widgets/empa_viewer.py#L161

@danielhollas danielhollas added this to the v.2.1.0 milestone Feb 24, 2023
@unkcpz unkcpz modified the milestones: v2.1.0, v2.2.0 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants