remove unused orm.implementation.utils module #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_attr` function defined here seems to be used nowhere in the codebase.
Codecov Report
@@ Coverage Diff @@
## develop #3877 +/- ##
===========================================
+ Coverage 77.16% 77.18% +0.02%
===========================================
Files 458 457 -1
Lines 33789 33779 -10
===========================================
Hits 26072 26072
+ Misses 7717 7707 -10
Continue to review full report at Codecov.
|
sphuber
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_attrfunction defined here seems to be used nowhere in thecodebase.
Note: this function was introduced in bc8bd0a and was used e.g. in
orm/implementation/django/nodes.py(but seems to be no longer).