BaseRestartWorkChain: do not assume metadata exists in inputs
#4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contract of the base restart work chain is that the `setup` will define the `self.ctx.inputs` attribute, however, it is not defined what its contents should be. The `run_process` method was unjustly assuming that the `metadata` key would be set to a dictionary, which is not always the case. In this fix, we simply check for its existence and create the dictionary if it doesn't yet exist.
Codecov Report
@@ Coverage Diff @@
## develop #4210 +/- ##
===========================================
+ Coverage 79.04% 79.11% +0.07%
===========================================
Files 467 467
Lines 34492 34492
===========================================
+ Hits 27260 27284 +24
+ Misses 7232 7208 -24
Continue to review full report at Codecov.
|
chrisjsewell
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4209
The contract of the base restart work chain is that the
setupwilldefine the
self.ctx.inputsattribute, however, it is not defined whatits contents should be. The
run_processmethod was unjustly assumingthat the
metadatakey would be set to a dictionary, which is notalways the case. In this fix, we simply check for its existence and
create the dictionary if it doesn't yet exist.