Fix to the exception message of the LinkManager #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link manager was always referring to an 'input link' while it should instead refer on an 'input link label' or 'output link label' depending on the value of the link direction, determined by the `self._incoming` attribute.
Codecov Report
@@ Coverage Diff @@
## develop #4388 +/- ##
===========================================
+ Coverage 79.22% 79.22% +0.01%
===========================================
Files 475 475
Lines 34822 34822
===========================================
+ Hits 27583 27584 +1
+ Misses 7239 7238 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ramirezfranciscof
approved these changes
Sep 24, 2020
Since this is a simple single-commit PR, we use a squash-merge. See the wiki for details on merge policy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link manager was always referring to an 'input link' while
it should instead refer on an 'input link label' or 'output link label'
depending on the value of the link direction, determined by the
self._incomingattribute.