Revert commits that break session commits released with v2.2.0 #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There currently is a bug in the `PsqlDosBackend` that when the session is commited during `QueryBuilder.iterall`, for example by creating a new ORM instance, an exception is raised. This bug was addressed in the commit 98e902b, however, this caused big problems that were not detected by the tests. Essentially, change were no longer automatically committed and so changes performed in a shell or by `verdi` commands would not get persisted to the database. The introduced bug was released with `v2.2.0` but the responsible commits have now been reverted. Here we add the test that demonstrates the original bug that the reverted commits were trying to address as described in aiidateam#5802. For now the test is skipped since it fails, but once the bug is properly fixed, without breaking everything else, it should be enabled.
sphuber
force-pushed
the
fix/5842/psql-dos-session-commit
branch
from
8a95702
to
162cd37
Compare
giovannipizzi
approved these changes
Dec 22, 2022
chrisjsewell
approved these changes
Dec 22, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5804 , which fixed #5802 and which was released with
v2.2.0introduced a way bigger bug that went unnoticed by the tests. Essentially, changes performed in a shell or byverdicommands are no longer committed and so not persisted to the database. I have been working on finding a fix without reverting, but it looks like this might take more time to do properly. I therefore propose to revert the relevant commits (while adding the test that fails due to #5802 , but skipping it for now) and make av2.2.1patch release. This is quite urgent becausev2.2.0is completely unusable at the moment.