fix: more flexible verdi status check #5862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`verdi status` was checking for the presence of the daemon by the name of the corresponding process. If the name was not as expected, it deleted (!) the PID file. On some systems, the name of the daemon process differed from the name expected by AiiDA, causing `verdi status` to delete the PID file of a correctly operating daemon.
ltalirz
force-pushed
the
fix/5336/daemon-status-circusd
branch
from
69457fe
to
6252b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verdi statuswas checking for the presence of the daemon by the name of the corresponding process. If the name was not as expected, it deleted (!) the PID file.On some systems, the name of the daemon process differed from the name expected by AiiDA, causing
verdi statusto delete the PID file of a correctly operating daemon.