Dependencies: Pin requirement sphinx~=7.2.0
#6527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6527 +/- ##
==========================================
+ Coverage 77.51% 77.82% +0.32%
==========================================
Files 560 564 +4
Lines 41444 41918 +474
==========================================
+ Hits 32120 32619 +499
+ Misses 9324 9299 -25 ☔ View full report in Codecov by Sentry. |
|
See bug report at Sphinx: sphinx-doc/sphinx#12579 Edit: The original bugs mentioned above have been fixed in releases v7.4.1 and v7.4.2 respectively, however, there are still two new warnings This is also likely due to the v7.4 release. |
sphuber
force-pushed
the
fix/sphinx-dependency
branch
from
91dae09
to
50b871a
Compare
The recently released v7.4.0 causes the build of the documentation to
fail with warnings of the type:
Failed to get a method signature for ...: unhashable type
It also leads to issues with incremental builds where it fails if
a build exists that was generated with an older version.
Both these bugs were fixed in v7.4.1 and v7.4.2 respectively, but more
warnings remain. Instead of waiting for these to be fixed, we are just
pinning to a minor version here which should anyway be done for optional
dev dependencies. There is no need to automatically update those to
latest releases.
sphuber
force-pushed
the
fix/sphinx-dependency
branch
from
50b871a
to
f40198c
Compare
sphuber
changed the title
sphinx~=7.2.1sphinx~=7.2.0
sphuber
added a commit
that referenced
this pull request
Aug 7, 2024
The recently released v7.4.0 causes the build of the documentation to
fail with warnings of the type:
Failed to get a method signature for ...: unhashable type
It also leads to issues with incremental builds where it fails if
a build exists that was generated with an older version.
Both these bugs were fixed in v7.4.1 and v7.4.2 respectively, but more
warnings remain. Instead of waiting for these to be fixed, we are just
pinning to a minor version here which should anyway be done for optional
dev dependencies. There is no need to automatically update those to
latest releases.
Cherry-pick: a610460
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
…team#6527) The recently released v7.4.0 causes the build of the documentation to fail with warnings of the type: Failed to get a method signature for ...: unhashable type It also leads to issues with incremental builds where it fails if a build exists that was generated with an older version. Both these bugs were fixed in v7.4.1 and v7.4.2 respectively, but more warnings remain. Instead of waiting for these to be fixed, we are just pinning to a minor version here which should anyway be done for optional dev dependencies. There is no need to automatically update those to latest releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently released v7.4.0 causes the build of the documentation to fail with warnings of the type: