Implement verdi work kill #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kCalculations's ABORTED_KEY
… fix_661_verdi_work_kill
…core into fix_661_verdi_work_kill
For WorkCalculations to be abortable through the kill() method the abort sequence of the Process had to be changed a bit. Upon abort, the ABORTED key will be set on the calculation node and the process will be put in the STOPPED state through .stop() The on_destroy method will check the state of the calculation and seal it when appropriate. The other point where the node can be sealed is in the ProcessFinaliser which will be hit if the process fails during a tick
The has_aborted check was added for WorkCalculations but the JobCalculations have no concept of an abort and therefore it was excepting in the on_destroy.
sphuber
added
topic/workflows
priority/critical-blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661
This also requires changes in plum and so will need a new support release
v0.7.10of plum.This has not yet been released and therefore has not been added to the
setup_requirements.pyyet.