CLI: filter cutoffs from JSON file for family cutoffs set #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbercx
force-pushed
the
fix/93/filter-cutoffs
branch
from
2d2be34
to
16f8fc2
Compare
Currently the `family cutoffs set` command requires that the JSON file that contains the cutoffs _only_ has the cutoff keys specified for each element. This is because the cutoffs are validated by the `RecommendedCutoffMixin.validate_cutoffs()` method, which doesn't allow for extraneous keys. However, the `.json` file could have been adapted by the user from e.g. the SSSP `metadata.json` or some other dictionary that also contains other keys. As long as the cutoff keys are defined, we shouldn't raise an error just because there are other keys present. Here we first filter the data loaded from the JSON file for the cutoffs, before passing the dictionary to the `set_cutoffs` method.
mbercx
force-pushed
the
fix/93/filter-cutoffs
branch
from
16f8fc2
to
63abf88
Compare
mbercx
force-pushed
the
fix/93/filter-cutoffs
branch
from
302688e
to
eb391cd
Compare
sphuber
approved these changes
Oct 10, 2022
|
Thanks @mbercx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
Currently the
family cutoffs setcommand requires that the JSON file that contains the cutoffs only has the cutoff keys specified for each element. This is because the cutoffs are validated by theRecommendedCutoffMixin.validate_cutoffs()method, which doesn't allow for extraneous keys.However, the
.jsonfile could have been adapted by the user from e.g. the SSSPmetadata.jsonor some other dictionary that also contains other keys. As long as the cutoff keys are defined, we shouldn't raise an error just because there are other keys present.Here we first filter the data loaded from the JSON file for the cutoffs, before passing the dictionary to the
set_cutoffsmethod.