Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having pw schema XML support all valide disk_io options #911

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Apr 12, 2023

fixes #908

Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
@unkcpz
Copy link
Member Author

unkcpz commented Apr 12, 2023

Okay, thanks change it back. I test locally and works all good.

@bastonero
Copy link
Collaborator

Passing by I'd suggest putting a reminder in the Wiki about this for future scheme releases. And maybe a test with a xml produced with a calculation specifying the disc_io with one of these options? (probably overtesting though)

@sphuber
Copy link
Contributor

sphuber commented Apr 13, 2023

And maybe a test with a xml produced with a calculation specifying the disc_io with one of these options? (probably overtesting though)

This is what @unkcpz added originally, but this will only protect against us accidentally modifying existing schema (specifically the one that is tested against) which is extremely unlikely, and it won't help against us adding a future schema that might not have the fix. So I suggested to leave the test as is.

@sphuber sphuber merged commit 89d39a4 into main Apr 13, 2023
@sphuber sphuber deleted the fix/908/disk_io-schema-check branch April 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The schema needs to updated to support more disk_io settings
3 participants