Support MPI executables (on a single process) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltalirz
force-pushed
the
issue_4_mpi_support
branch
from
1cb17f0
to
6b3c2ae
Compare
Previously, the mock executable would * replace its name in the submit script with the fallback executable * run the submit script using bash This approach obviously does not work in conjunction with MPI, since it ends up calling `mpirun` inside `mpirun. This PR changes the mock executable to simply call the fallback executable directly, using the command line arguments that were provided. Environment variables are forwarded to the subprocess automatically using `subprocess.call`.
ltalirz
force-pushed
the
issue_4_mpi_support
branch
from
6b3c2ae
to
4212ba8
Compare
greschd
previously approved these changes
Nov 21, 2022
|
LGTM, apart from the suggestion above (remove outdated comment). |
Co-authored-by: Dominik Gresch <greschd@users.noreply.github.com>
|
Thanks for the quick review @greschd, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #45 and makes it possible to run executables through
mpirun, but on a single-process only(!).Previously, when the mock executable would detect that an input is not present in the cache, it would
This approach obviously does not work in conjunction with MPI, since it ends up calling
mpiruntwice: once for running the mock executable, and once again inside the mock executable when it calls the submit script again.This PR changes the mock executable to simply call the fallback executable directly, using the command line arguments that were provided.
Environment variables are forwarded to the subprocess automatically using
subprocess.call.This works for running with
-np 1, but it still does not solve running with more than one process (one should probably add a check).