Add GitHub actions CI #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
So this has become a bit of an unwieldy PR - if desired I can separate the "move to GHA" from the "drop Python3.5, add Python3.9" to get more manageable chunks. Currently these two steps are just separate commits. Note that those probably shouldn't be squashed together when merging. |
Because the pylint bundled with latest prospector is incompatible with Python 3.9 (at least partially), we drop prospector in favor of an updated pylint. The change in pylint version required some changes to make the code pass.
giovannipizzi
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
Part 1 of moving to GHA (#54): Travis CI still enabled. Will remove that once we switched over. The actions can be viewed at https://github.com/greschd/qe-tools/actions
Using the same setup as for
aiida-wannier90: The workflows are defined in.github/workflows_sourceusing YAML anchors, which are expanded into.github/workflowsby the script.utils/interpolate_yaml_anchors.py.Drops support for Python 3.5, adds 3.9 to the CI matrix. As a consequence the
prospectorrun fails, which is why I have replaced it with a plainpylintand made some minor changes to make that pass.Also added a top-level
reposto.pre-commit-config.yaml, because my editor complained about that not matching the schema 🙃