Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty completion on BungeeCord #243

Open
Proximyst opened this issue Oct 6, 2019 · 2 comments
Open

Empty completion on BungeeCord #243

Proximyst opened this issue Oct 6, 2019 · 2 comments
Labels
bug bungee Related to the ACF Bungee Implementation

Comments

@Proximyst
Copy link
Contributor

When using acf-bungee, on completion it suggests an empty argument when there are nothing but subcommands available; it includes all subcommands (as expected), but drops an empty string at the top.

https://uwu.whats-th.is/6QLLsJ6.png

For commands which are simply the root command and have completions set up with @Default, it works just fine:

https://proletariat-dictatorship.is-serious.business/8dRMfaz.png

@MrIvanPlays
Copy link
Contributor

MrIvanPlays commented Dec 25, 2019

It has to do something with the @empty completion as I've seen weird behaviour of it at bungee.

EDIT: The problem is being this line of code. Unlike Bukkit, BungeeCord doesn't check for empty strings and so adds all completions no matter what they are.

@MrIvanPlays
Copy link
Contributor

Instead of modifying ACF, I will make a PR in BungeeCord to prevent empty completions.

MrIvanPlays added a commit to MrIvanPlays/BungeeCord that referenced this issue Dec 28, 2019
This commit fixes aikar/commands#243 .
Some people will ask why not opening a PR in ACF to fix it there? Because in general, BungeeCord shouldn't be adding empty completions!
@chickeneer chickeneer added bug bungee Related to the ACF Bungee Implementation labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bungee Related to the ACF Bungee Implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants