Include generics to get test cases working #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroProofs
changed the title
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
145dc5b
to
6bf313a
Compare
|
Rebased, added a new test (tried to work around test |
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
6bf313a
to
5c94f80
Compare
rvcas
force-pushed
the
some-interesting-test-cases
branch
2 times, most recently
from
db4784c
to
8af4685
Compare
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
8af4685
to
c8f3def
Compare
KtorZ
added a commit
to aiken-lang/stdlib
that referenced
this pull request
Dec 13, 2022
Few TODOs from there:
- [] Seems like the parser can't parse negative literals.
Current work-around: write as `0 - n` instead of `-n`.
- [] The formatter confuses tuples with function arguments
in expression blocks. So writing:
```
let (xs, ys) = unzip(rest)
([x, ..xs], [y, ..ys])
```
is wrongly turned into:
```
let (xs, ys) = unzip(rest)([x, ..xs], [y, ..ys])
```
- [] Inline comments and function documentation comments are wrongly
grouped together by the formatter.
- [] The compiler panicks when two tests have the same name:
```
test foo() { todo }
test foo() { todo }
```
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/tipo/infer.rs:181:43
╰─▶ Could not find hydrator for fn
help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.
```
- As well as any acceptance tests added to: aiken-lang/aiken#166
test b passes
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/uplc.rs:3264:35
╰─▶ called `Option::unwrap()` on a `None` value
help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.
```
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/uplc.rs:1518:45
╰─▶ called `Option::unwrap()` on a `None` value
help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.
```
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/uplc.rs:4043:46
╰─▶ not yet implemented
help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.
```
…{1,2,3,4,5,6}
Also added a little Makefile to run them all in one go.
```
Error: aiken::check
× Checking
╰─▶ Not a function
╭─[./007/lib/test.ak:4:1]
4 │ [(a, b), ..rest] -> {
5 │ let (a_tail, b_tail) = unzip(rest)
· ──────
6 │ ([a, ..a_tail], [b, ..b_tail])
╰────
```
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/uplc.rs:530:41
╰─▶ not yet implemented
help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.
```
Note: the problem is only present when importing a builtin explicitly.
When using a qualified import, it compiles fine.
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/uplc.rs:3264:35
╰─▶ called `Option::unwrap()` on a `None` value
help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.
```
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/uplc.rs:688:33
╰─▶ called `Option::unwrap()` on a `None` value
help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.
```
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/uplc.rs:4022:40
╰─▶ called `Option::unwrap()` on a `None` value
```
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/uplc.rs:3413:34
╰─▶ internal error: entered unreachable code: Var {
scope: [
0,
1,
3,
24,
25,
29,
32,
],
constructor: ValueConstructor {
public: false,
variant: LocalVariable {
location: 46..62,
},
tipo: Fn {
args: [
Var {
tipo: RefCell {
value: Link {
tipo: App {
public: true,
module: "",
name: "Int",
args: [],
},
},
},
},
],
ret: App {
public: true,
module: "",
name: "Bool",
args: [],
},
},
},
name: "f",
variant_name: "",
}
```
``` ERROR: The provided Plutus code called 'error' ```
Pretty useful for debbugging. Though, on second-thoughts, this is something we may want to review later and maybe have that done by default for tests. At the moment, we expects tests to unify to `bool`, and treat `false` values as failing tests. Yet, on failures, this gives little information about what's wrong with the test. It'd be nice to either have better way to assert in tests, or, to simply accept non-bool tests, and show whatever the test evaluates to as a debug output.
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
3541bad
to
3c664b9
Compare
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/uplc.rs:2388:21
╰─▶ not yet implemented
```
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
6bc5806
to
bd956ef
Compare
KtorZ
added a commit
to aiken-lang/stdlib
that referenced
this pull request
Dec 14, 2022
Few TODOs from there:
- [] Seems like the parser can't parse negative literals.
Current work-around: write as `0 - n` instead of `-n`.
- [] The formatter confuses tuples with function arguments
in expression blocks. So writing:
```
let (xs, ys) = unzip(rest)
([x, ..xs], [y, ..ys])
```
is wrongly turned into:
```
let (xs, ys) = unzip(rest)([x, ..xs], [y, ..ys])
```
- [] Inline comments and function documentation comments are wrongly
grouped together by the formatter.
- [] The compiler panicks when two tests have the same name:
```
test foo() { todo }
test foo() { todo }
```
```
Error:
× Main thread panicked.
├─▶ at crates/lang/src/tipo/infer.rs:181:43
╰─▶ Could not find hydrator for fn
help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.
```
- As well as any acceptance tests added to: aiken-lang/aiken#166
And integrated test results with miette report.
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
cf4bf64
to
87546e0
Compare
Was introduced as a work-around to get some debugging info out of scripts, but tests do now provide the same capability with a better output and, do so automatically.
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
3a21167
to
e597264
Compare
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
38d44d9
to
5024bd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.