-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More acceptance test scenarios. #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
added a commit
to aiken-lang/stdlib
that referenced
this pull request
Dec 15, 2022
- Slightly more efficient until we have compiler optimizations in. - Also 'solves' issue captured in acceptance tests 016 and 017 (see aiken-lang/aiken#176)
KtorZ
added a commit
to aiken-lang/stdlib
that referenced
this pull request
Dec 15, 2022
- Slightly more efficient until we have compiler optimizations in. - Also 'solves' issue captured in acceptance tests 016 and 017 (see aiken-lang/aiken#176)
MicroProofs
force-pushed
the
some-interesting-test-cases
branch
from
December 16, 2022 00:24
220b6fa
to
b61b1c5
Compare
KtorZ
commented
Dec 16, 2022
@@ -6,6 +6,7 @@ pub fn new() { | |||
Map { inner: [] } | |||
} | |||
|
|||
// Seems to be an issue with the parser. The TypedExpr body is excluding the Equal binop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can have a look at that one.
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
December 17, 2022 14:06
5071b66
to
79f2360
Compare
``` Error: × Main thread panicked. ├─▶ at /Users/ktorz/Documents/Projects/aiken-lang/aiken/crates/project/src/lib.rs:616:36 ╰─▶ called `Result::unwrap()` on an `Err` value: FreeUnique(Name { text: "test_slice", unique: Unique(7) }) ```
``` Error: × Main thread panicked. ├─▶ at /Users/ktorz/Documents/Projects/aiken-lang/aiken/crates/project/src/lib.rs:596:22 ╰─▶ called `Result::unwrap()` on an `Err` value: FreeUnique(Name { text: "test_slice", unique: Unique(6) }) ```
``` Error: examples/acceptance_tests/018/lib/test.ak × or_else_2 failed help: ┍━ left ━━━━━━━━━━━┑ │ (con data #182a) │ ┕━━━━━━━━━━━━━━━━━━┙ should be equal to ┍━ right ━━━━━━━━━━┑ │ (con integer 42) │ ┕━━━━━━━━━━━━━━━━━━┙ ```
``` Error: × Main thread panicked. ├─▶ at crates/lang/src/uplc.rs:2001:81 ╰─▶ called `Option::unwrap()` on a `None` value ```
``` Error: 020/lib/test.ak × map_2 failed help: ┍━ left ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┑ │ Type mismatch expected 'integer' got 'data' │ ┕━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┙ should be equal to ┍━ right ━━━━━━━━━━━━━━━━┑ │ (con data #d8799f0fff) │ ┕━━━━━━━━━━━━━━━━━━━━━━━━┙ ```
``` Error: aiken::check × Checking ╰─▶ Unknown type VerificationKey ╭─[021/lib/test.ak:4:1] 4 │ pub type PoolId = 5 │ Hash<VerificationKey> · ─────────────── 6 │ ╰──── ```
and Inner function issues with variant
This is because there's no proper way to catch panics in Rust, which makes it hard to know _which_ test did cause the panic when this happen. The stack trace gives little detail about this, but we can print this information before it happens -- making it easier to identify the culprit.
``` thread 'main' has overflowed its stack fatal runtime error: stack overflo ```
It's best to keep builtin as-close-as possible to their standard name because they're hard to document. We can then leverage the prelude and the standard lib for convenient names.
KtorZ
force-pushed
the
some-interesting-test-cases
branch
from
December 17, 2022 16:10
fa7e3ae
to
5fb9060
Compare
MicroProofs
force-pushed
the
some-interesting-test-cases
branch
from
December 18, 2022 03:05
8fa0f88
to
8dca5eb
Compare
MicroProofs
approved these changes
Dec 18, 2022
Instead, prints out a README with useful informations.
Use more cost efficient recurse Monomorphize needed to deal with function arg return types bytearray variant added for variant names
One test left to pass and that will be fixed in pr #164. Let's merge for now |
rvcas
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.