Decomoposing and code improvement #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Tests and other files changed appropriately. 3. Small fix in pyproject.toml.
Networks: decomposing, code improvement; Tests: Update because of new soft structure; New test for models without pickle path.
jrzkaminski
approved these changes
Mar 28, 2023
Roman223
changed the title
Roman223
changed the title
Roman223
changed the title
Roman223
changed the title
Closed
Roman223
changed the title
Anaxagor
requested changes
Mar 29, 2023
jrzkaminski
requested changes
Mar 29, 2023
There was a problem hiding this comment.
Please also update docs, by changing the auto-generated API section.
You can find an instruction on updating documentation here:
https://bamt.readthedocs.io/en/latest/getting_started/contribution.html
nicl-nno
reviewed
Mar 31, 2023
nicl-nno
reviewed
Mar 31, 2023
bamt/builders.py
Outdated
Comment on lines
128
to
131
| if type in ['disc_num', 'disc']: | ||
| Node = nodes.DiscreteNode(name=vertex) | ||
| node = discrete_node.DiscreteNode(name=vertex) | ||
| elif type == 'cont': | ||
| Node = nodes.GaussianNode(name=vertex, regressor=regressor) | ||
| node = gaussian_node.GaussianNode(name=vertex, regressor=regressor) |
There was a problem hiding this comment.
Возможно, вот эту часть стоит переработать в виде Factory.
nicl-nno
reviewed
Mar 31, 2023
nicl-nno
reviewed
Mar 31, 2023
bamt/networks/base.py
Outdated
| @@ -170,7 +169,7 @@ def calculate_weights(self, discretized_data: pd.DataFrame): | |||
| """ | |||
| import bamt.utils.GraphUtils as gru | |||
| if not all([i in ['disc', 'disc_num'] | |||
| for i in gru.nodes_types(discretized_data).values()]): | |||
| for i in gru.nodes_types(discretized_data).values()]): | |||
There was a problem hiding this comment.
Для большей читаемости лучше gru.nodes_types(discretized_data).values() вынести в переменную.
И переработать в all([node_type in discrete_types for node_type in nodes_types])
Можно в целом вынести такую проверку в функцию вроде is_discrete - явно где-то ещё может понадобится.
nicl-nno
reviewed
Mar 31, 2023
nicl-nno
reviewed
Mar 31, 2023
nicl-nno
reviewed
Mar 31, 2023
nicl-nno
reviewed
Mar 31, 2023
nicl-nno
reviewed
Mar 31, 2023
nicl-nno
reviewed
Mar 31, 2023
This was referenced Mar 31, 2023
Anaxagor
approved these changes
Apr 1, 2023
nicl-nno
approved these changes
Apr 1, 2023
jrzkaminski
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Networks and nodes
Classes were separated into files
Test for models implemented.