Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log module API #93

Merged
merged 17 commits into from
Dec 27, 2023
Merged

Log module API #93

merged 17 commits into from
Dec 27, 2023

Conversation

Roman223
Copy link
Collaborator

@Roman223 Roman223 commented Nov 28, 2023

There will be no files created by bamt by default anymore. Instead:

  1. API for logging module is implemented.
  2. For more details, see new section of docs: "Setting up loggers".
  3. FAQ Section updated.
  4. Minor fix: plots will be displayed in cells in Jupiter.

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Qodana for Python

1 new problem were found

Inspection name Severity Problems
Method is not declared static ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@Roman223 Roman223 marked this pull request as ready for review December 15, 2023 12:26
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Qodana for Python

2 new problems were found

Inspection name Severity Problems
Method is not declared static ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (28685d0) 65.73% compared to head (f53036a) 65.49%.

Files Patch % Lines
bamt/log.py 48.48% 17 Missing ⚠️
bamt/networks/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   65.73%   65.49%   -0.25%     
==========================================
  Files          43       42       -1     
  Lines        2913     2904       -9     
==========================================
- Hits         1915     1902      -13     
- Misses        998     1002       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bamt/log.py Outdated Show resolved Hide resolved
Roman223 and others added 3 commits December 20, 2023 14:25
Fromal style

Co-authored-by: Jerzy Kamiński <86363785+jrzkaminski@users.noreply.github.com>
Getting rid of nested loops

Co-authored-by: Jerzy Kamiński <86363785+jrzkaminski@users.noreply.github.com>
@Roman223 Roman223 merged commit 77ffcf6 into master Dec 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants