Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc_weight fix #98

Merged
merged 2 commits into from
Dec 14, 2023
Merged

calc_weight fix #98

merged 2 commits into from
Dec 14, 2023

Conversation

Roman223
Copy link
Collaborator

Method _estimate_probabilities was recovered.

Minor improvement in our calullate_weights method.

@Roman223 Roman223 added the bug Something isn't working label Dec 13, 2023
@pep8speaks
Copy link

pep8speaks commented Dec 13, 2023

Hello @Roman223! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 153:17: E126 continuation line over-indented for hanging indent
Line 160:17: W503 line break before binary operator
Line 161:13: E122 continuation line missing indentation or outdented
Line 162:13: E122 continuation line missing indentation or outdented
Line 163:13: E122 continuation line missing indentation or outdented
Line 164:13: E122 continuation line missing indentation or outdented
Line 165:13: E122 continuation line missing indentation or outdented
Line 166:9: E122 continuation line missing indentation or outdented
Line 167:17: W503 line break before binary operator
Line 168:13: E122 continuation line missing indentation or outdented
Line 169:13: E122 continuation line missing indentation or outdented
Line 170:13: E122 continuation line missing indentation or outdented
Line 171:13: E122 continuation line missing indentation or outdented
Line 172:13: E122 continuation line missing indentation or outdented
Line 173:9: E122 continuation line missing indentation or outdented
Line 174:17: W503 line break before binary operator
Line 488:17: E126 continuation line over-indented for hanging indent
Line 489:17: W503 line break before binary operator
Line 490:17: W503 line break before binary operator
Line 491:17: W503 line break before binary operator
Line 648:21: E126 continuation line over-indented for hanging indent
Line 726:19: E127 continuation line over-indented for visual indent

Comment last updated at 2023-12-13 14:40:40 UTC

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Qodana for Python

39 new problems were found

Inspection name Severity Problems
PEP 8 naming convention violation ◽️ Notice 25
PEP 8 coding style violation ◽️ Notice 14

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (43b0a39) 65.70% compared to head (e2832a5) 65.70%.

Files Patch % Lines
bamt/networks/base.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   65.70%   65.70%           
=======================================
  Files          43       43           
  Lines        2913     2913           
=======================================
  Hits         1914     1914           
  Misses        999      999           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roman223 Roman223 merged commit 28685d0 into master Dec 14, 2023
6 checks passed
@Roman223 Roman223 deleted the calc_weight_fix branch December 14, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants