-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch OneHotEncoder to LabelEncoder #1196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Стоит проверить, работает или нет. Если действительно работает, то хорошо.
Только в мастер это не стоит лить, лучше в отдельную ветку |
Там тесты падали. Как я думал, ветку будут использовать отдельно в экспериментах прежде чем лить в мастер |
Hello @aPovidlo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-11-21 13:51:32 UTC |
В целом те тесты где проверяется размерность выхода можно просто отключить в этой ветке. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
- Coverage 79.49% 79.39% -0.10%
==========================================
Files 145 145
Lines 10022 10022
==========================================
- Hits 7967 7957 -10
- Misses 2055 2065 +10 ☔ View full report in Codecov by Sentry. |
Migrate to #1004 Preprocessor acceleration |
Change default categories encoder as LabelEncoder in preprocessing