-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sporadic forecasting test failure #1280
Conversation
👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app Simply create a new comment in this PR that says: @docu-mentor run and I will start my analysis. I only look at what you changed @docu-mentor run doc/ README.md In this example, I'll have a look at all files contained in the "doc/" |
All PEP8 errors has been fixed, thanks ❤️ Comment last updated at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
- Coverage 79.92% 79.90% -0.03%
==========================================
Files 146 146
Lines 10049 10065 +16
==========================================
+ Hits 8032 8042 +10
- Misses 2017 2023 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Запусти 2 раза интеграционники на этой ветке, если все ок -вливай
|
||
# check ets params according to statsmodels restrictions | ||
self._check_and_correct_params(endog) | ||
self.log.info(f'Changed the following ETSModel parameters: {self.params.changed_parameters}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лучше сделать так:
if self._check_and_correct_params(endog) # need to change return statement
self.log.info(f'Changed the following ETSModel parameters: {self.params.changed_parameters}')
Чтобы не вводить юзера в заблуждение, что параметры меняются (а они могут и не поменяться)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a 🐛 bug fix.
Summary
ETSModel
parameters to avoid NaNs in the fitted data 47371c0Context
closes #1279