Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartbanner.js@1.5.0: The engine "node" is incompatible with this module. Expected version "^6.2.0". #57

Closed
stanogurnik opened this issue Jul 17, 2017 · 4 comments

Comments

@stanogurnik
Copy link

Using node v8.1.4. There is no reason to force using node 6

@ain
Copy link
Owner

ain commented Jul 17, 2017

There is. v8 is a major version which could mean a breaking change. smartbanner.js has not been tested on v8.

But I agree, we should upgrade this. Thanks for the ticket.

@duyleekun
Copy link

Tried to use with https://github.com/angulartics/angulartics2 which requires v8. Now stuck :)

@ain
Copy link
Owner

ain commented Jul 28, 2017

If tests go well I'll push a new release with v8 support over the weekend.

@duyleekun
Copy link

Yeah, it's not urgent since I can ignore the error with yarn :D I don't thing npm even check it :)

ain added a commit that referenced this issue Aug 9, 2017
@ain ain closed this as completed in #61 Aug 9, 2017
ain added a commit that referenced this issue Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants