Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix websocket module import error #178

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix websocket module import error #178

merged 1 commit into from
Apr 22, 2024

Conversation

platfowner
Copy link
Member

Change summary:

  • Fix websocket module import error

Related issues:

@platfowner platfowner added the bug Something isn't working label Apr 22, 2024
jiyoung-an
jiyoung-an approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@jiyoung-an jiyoung-an left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!
It also works well in the browser!

@platfowner
Copy link
Member Author

@platfowner it also works well in browser!

very happy to hear that! 😄 thanks for checking.

@platfowner
Copy link
Member Author

Thanks for the fast review! @jiyoung-an Now merging..

@platfowner platfowner merged commit ec53d11 into develop Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyoung-an jiyoung-an jiyoung-an approved these changes

@shyun-comcom shyun-comcom Awaiting requested review from shyun-comcom

@yoojinko yoojinko Awaiting requested review from yoojinko

@akastercomcom akastercomcom Awaiting requested review from akastercomcom

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@platfowner @jiyoung-an