Use default coords if userGps not available. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
liayoo
commented
Apr 21, 2020
liayoo
commented
- Use default coords if userGps not available
- Set maxZoom
ehdgus8077
approved these changes
Apr 21, 2020
| const markers = useRef([]); | ||
| const mapRef = useRef(null); | ||
| const mapContainerRef = useRef(null); | ||
| const gpsRef = useRef(userGps); |
There was a problem hiding this comment.
userGps를 바로 사용하지 않고, useRef를 이용하여 따로 만든 이유를 알 수 있을까요?
There was a problem hiding this comment.
setTimeout 같은 경우 useState hook으로는 업데이트가 안되서 이렇게 했습니다 (related: facebook/react#14010) usePosition이 App.js 에서 더이상 안쓰이고 있어서 Map.js로 옮겨왔어도 되긴한데.. 그래도 useRef를 사용해야하긴 마찬가지일듯합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.