Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Distinct error for futures cancellation #316

Merged
merged 2 commits into from
Nov 7, 2017

Conversation

popravich
Copy link
Contributor

Cancel pending futures with one of distinct errors (ConnectionClosedError,
ConnectionForcedCloseError or builtin exception like ConnectionError)
instead of calling cancel() method.

@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #316 into master will decrease coverage by 0.08%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage    96.9%   96.82%   -0.09%     
==========================================
  Files          60       60              
  Lines        7659     7679      +20     
  Branches      609      611       +2     
==========================================
+ Hits         7422     7435      +13     
- Misses        175      179       +4     
- Partials       62       65       +3
Impacted Files Coverage Δ
tests/integrational_test.py 96.61% <ø> (ø) ⬆️
tests/transaction_commands_test.py 100% <100%> (ø) ⬆️
aioredis/errors.py 100% <100%> (ø) ⬆️
aioredis/commands/transaction.py 83.33% <50%> (-3.63%) ⬇️
tests/connection_commands_test.py 94.44% <66.66%> (-1.64%) ⬇️
examples/py34/connection.py 92.03% <0%> (-0.59%) ⬇️
tests/conftest.py 89.97% <0%> (-0.51%) ⬇️
tests/sentinel_failover_test.py 87.96% <0%> (+0.75%) ⬆️
aioredis/util.py 92% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf3e5c...e4e8394. Read the comment docs.

@popravich
Copy link
Contributor Author

This would resolve #306 and #190

@popravich popravich force-pushed the explicit_waiters_cancellation branch from cf56319 to baf8d56 Compare November 7, 2017 14:58
@popravich popravich force-pushed the explicit_waiters_cancellation branch from baf8d56 to e4e8394 Compare November 7, 2017 15:00
@popravich popravich merged commit f391c68 into master Nov 7, 2017
@popravich popravich deleted the explicit_waiters_cancellation branch November 8, 2017 08:01
@popravich popravich added this to the v1.0 milestone Nov 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant