Changelog for 1.3.5 seems to be missing

[jayfk]

Long story short

The latest release in https://github.com/aio-libs/aiohttp/blob/master/HISTORY.rst is 1.3.4 and https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst begins at 2.0.0rc1.

Expected behaviour

Have a changelog for 1.3.5.

Actual behaviour

No changelog for 1.3.5.

Steps to reproduce

Open

• https://github.com/aio-libs/aiohttp/blob/master/HISTORY.rst
• https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst

CTRL/CMD + F

[jayfk]

Looks like the release page on PyPi has it: https://pypi.python.org/pypi/aiohttp

Forgot to commit and push CHANGES.rst?

[fafhrd91]

https://github.com/aio-libs/aiohttp/blob/1.3/CHANGES.rst

[samuelcolvin]

We shouldn't have HISTORY.rst and CHANGES.rst, it's confusing for both users and pyup.

[fafhrd91]

Changes.rst contains only last release changes. Otherwise changes.rst would be huge

[samuelcolvin]

Well whatever we do it should work with pyup as that description of changes in PRs is extremely useful. I see no problem with a huge changelog.

[jayfk]

We shouldn't have HISTORY.rst and CHANGES.rst, it's confusing for both users and pyup.

While I agree that this is confusing, it isn't a problem for pyup to parse the changelog. The underlying issue is that the 1.3.5 changelog wasn't merged back into master and seems to only appear on the 1.3 branch.

I can understand why that's been done, but I think that's even more confusing. As a user (and tool author) I'd expect to see the full changelog of all available releases on the master branch.

[fafhrd91]

I do not this it is problem in general. It is just current situation with 2.0, usually it takes much less time and amount of changes to make new release

[fafhrd91]

Help is welcome

[samuelcolvin]

I'm still not clear what the problem would be with just HISTORY.rst which contains all changes back to the beginning of time?

That would be clear for users and afaik would work with pyup/changelog.

If that's an acceptable solution I'll happily submit a PR.

[fafhrd91]

ok

[fafhrd91]

I fixed history

[jayfk]

thanks 👍🏼

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.