Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate trustme for testing TLS support against a "real CA" with "real" certificates #3487

Closed
wants to merge 3 commits into from
Closed

Integrate trustme for testing TLS support against a "real CA" with "real" certificates #3487

wants to merge 3 commits into from

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Jan 5, 2019 •
edited
Loading

What do these changes do?

  1. Remove hardcoded static TLS certificates
  2. Integrate https://trustme.readthedocs.io/en/latest/ in place of those which emulates a real CA, so no self-signed crap anymore (Yaaay!)
  3. Enable real TLS context in place of mocks or disabled checks

Are there changes in behavior for the user?

Not really

Related issue number

I mentioned it @ #3180 (comment) if that counts

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz requested a review from asvetlov January 5, 2019 02:15
@webknjaz webknjaz force-pushed the testing/trustme-integration branch 3 times, most recently from 5ff0f5e to 50417f1 Compare January 5, 2019 11:31
@webknjaz webknjaz closed this in c180800 Jan 5, 2019
asvetlov pushed a commit that referenced this pull request Jan 5, 2019
@webknjaz @asvetlov
[3.5] Integrate trustme fake CA lib for testing TLS
1109f33 
Also:
* Use real TLS context where it's disabled in tests
* Add a change note about trustme integration

Closes #3487.
(cherry picked from commit c180800)

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
@asvetlov asvetlov mentioned this pull request Jan 5, 2019
Merged
5 tasks
asvetlov added a commit that referenced this pull request Jan 5, 2019
@asvetlov @webknjaz
[3.5] Integrate trustme fake CA lib for testing TLS (#3489)
08a6902 
Also:
* Use real TLS context where it's disabled in tests
* Add a change note about trustme integration

Closes #3487.
(cherry picked from commit c180800)

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
@dotlambda
Copy link
Contributor

Trustme should be added to test_require.

dotlambda pushed a commit to dotlambda/aiohttp that referenced this pull request Jan 10, 2019
tests_require: add trustme
c5693e7 
It is required since aio-libs#3487.
@dotlambda dotlambda mentioned this pull request Jan 10, 2019
Closed
5 tasks
@asvetlov asvetlov deleted the testing/trustme-integration branch September 7, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webknjaz @dotlambda