Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make force attr for ClientResponse.close() True by default #479

Closed
asvetlov opened this issue Aug 30, 2015 · 5 comments
Closed

Make force attr for ClientResponse.close() True by default #479

asvetlov opened this issue Aug 30, 2015 · 5 comments
Labels
Milestone

Comments

@asvetlov
Copy link
Member

resp.close(force=False) is not safe: you should make sure that all response body has been read.
That can be done by yield from resp.release() call.
So let's change .close() to forcing close behavior. This simplifies response usage rules.

Appliying .close(force=False) should produce DeprecationWarning in next releases (say, until New Year). After that let's remove the parameter completely.

@fafhrd91
Copy link
Member

is there other way to force close request socket?

@asvetlov
Copy link
Member Author

@fafhrd91 except resp.close(force=True)? I'm not aware about alternatives.

@fafhrd91
Copy link
Member

oh, i misunderstand description. +1

@asvetlov asvetlov added this to the 0.18 milestone Sep 1, 2015
@asvetlov asvetlov mentioned this issue Sep 1, 2015
@asvetlov
Copy link
Member Author

asvetlov commented Sep 1, 2015

Done

@asvetlov asvetlov closed this as completed Sep 1, 2015
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants