Fix use of deprecated SQLAlchemy functionality in tests #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following deprecation warning: SADeprecationWarning: The FromClause.count() method is deprecated, and will be removed in a future release. Please use the count function available from the func namespace. References: https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Table.count https://docs.sqlalchemy.org/en/13/core/functions.html#sqlalchemy.sql.functions.count
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 38 38
Lines 5569 5569
Branches 943 943
=======================================
Hits 5164 5164
Misses 317 317
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes the following deprecation warning:
SADeprecationWarning: The FromClause.count() method is deprecated, and will be removed in a future release. Please use the count function available from the func namespace.References:
https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Table.count
https://docs.sqlalchemy.org/en/13/core/functions.html#sqlalchemy.sql.functions.count
Are there changes in behavior for the user?
No, tests only.