Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct doc (deprecated warning from aiohttp) #264

Closed
anton-tagunov opened this issue Apr 1, 2019 · 1 comment
Closed

Correct doc (deprecated warning from aiohttp) #264

anton-tagunov opened this issue Apr 1, 2019 · 1 comment

Comments

@anton-tagunov
Copy link

The example in readme contains the call of make_handler https://github.com/aio-libs/sockjs/blame/master/README.rst#L30.
But it is deprecated:

Application.make_handler(...) is deprecated, use AppRunner API instead

Please correct example.
Cykooz added a commit to Cykooz/sockjs that referenced this issue Oct 21, 2020
@Cykooz
Fixed examples of using of SockJS server (aio-libs#264).
caad72f
@Cykooz Cykooz mentioned this issue Oct 21, 2020
Merged
Cykooz added a commit to Cykooz/sockjs that referenced this issue Oct 21, 2020
@Cykooz
Fixed examples of using of SockJS server (aio-libs#264).
cecfece
Cykooz added a commit that referenced this issue Oct 21, 2020
@Cykooz
Merge pull request #388 from Cykooz/master
67d919c 
Fixed examples of using of SockJS server (#264).
@Cykooz
Copy link
Member

Cykooz commented Oct 21, 2020

Fixed in #388

@Cykooz Cykooz closed this as completed Oct 21, 2020
Cykooz added a commit to Cykooz/sockjs that referenced this issue Oct 22, 2020
@Cykooz
- Fixed examples of using of SockJS server (aio-libs#264).
8e0609e 
- Bump to 0.11.0
@Cykooz Cykooz mentioned this issue Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cykooz @anton-tagunov