Prevent copying tmp dir to itself in build backend #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, setting `TMPDIR="$(pwd)/smth-inside"` would cause the in-tree PEP 517 build backend to go into infinite recursion, attempting to copy the project directory into a nested folder. Specifically, this is happening in the Fedora land because macros used in RPM packaging (`pyproject-rpm-macros`) are setting it up like this. Additionally, this is only happening with `pip wheel` and doesn't affect `pyproject-build`, because the latter pre-copies the project directory by itself early, and changes current working directory to it while the former does not. This patch addresses the issue by excluding the temporary directory from traversal when copying the directory tree within the build backend. Fixes aio-libs#992.
This patch further improves Miro's submission 80ae8b6 to move the ignoring logic into a top-level helper function and exclude the parent tmp root directory, not just its subfolders.
webknjaz
added a commit
to webknjaz/yarl
that referenced
this pull request
May 30, 2024
webknjaz
force-pushed
the
bugfixes/992-packaging-in-tree-backend-tmp-copy-logic
branch
from
7a22d32
to
3d5a01b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, setting
TMPDIR="$(pwd)/smth-inside"would cause thein-tree PEP 517 build backend to go into infinite recursion,
attempting to copy the project directory into a nested folder.
Specifically, this is happening in the Fedora land because macros
used in RPM packaging (
pyproject-rpm-macros) are setting it uplike this. Additionally, this is only happening with
pip wheelanddoesn't affect
pyproject-build, because the latter pre-copies theproject directory by itself early, and changes current working
directory to it while the former does not.
This patch addresses the issue by excluding the temporary directory
from traversal when copying the directory tree within the build
backend.
Fixes #992.