Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerized bot shuts down ungracefully #4

Closed
eyev0 opened this issue Jun 20, 2020 · 0 comments · Fixed by #5
Closed

dockerized bot shuts down ungracefully #4

eyev0 opened this issue Jun 20, 2020 · 0 comments · Fixed by #5
Labels
bug Something isn't working

Comments

@eyev0
Copy link
Contributor

eyev0 commented Jun 20, 2020

Using entrypoint causes docker to spawn another process to execute python, and it doesn't receive stop signals. This leaves on_shutdown events unexecuted.
eyev0 pushed a commit to eyev0/bot that referenced this issue Jun 20, 2020
add exec to docker-entrypoint.sh command
1555077 
fixes aiogram#4
Found solution [here](https://hynek.me/articles/docker-signals/)
@eyev0 eyev0 mentioned this issue Jun 20, 2020
Merged
@JrooTJunior JrooTJunior added the bug Something isn't working label Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add exec to docker-entrypoint.sh command eyev0/bot
2 participants
@JrooTJunior @eyev0