Prevent double delays and add some docs #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just noticed that reusing `delay` for the poll interval will cause an unintended double delay (first the delay is used as interval, and when a change happened delay is used to wait before building after the change). Adding a dedicated `poll_interval` parameter allows people to prevent that and apply a more fine-grained configuration. Also added the new params to the example toml file with some docs which I forgot to do in the initial PR.
cosmtrek
reviewed
Apr 13, 2023
|
Thanks for the contribution. I've reviewed the code and left some comments. |
|
Thanks! If possible, could you maybe set a new tag so we can use that instead of |
|
Just noticed the tag, thanks for being so responsive and helpful 👍🏻 Much appreciated! |
|
Sounds this may fix what I've seen in #343 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that reusing
delayfor the poll interval will cause an unintended double delay (first the delay is used as interval, and when a change happened delay is used to wait before building after the change).Adding a dedicated
poll_intervalparameter allows people to prevent that and apply a more fine-grained configuration.Also added the new params to the example toml file with some docs which I forgot to do in the initial PR and "fixed" a few linter warnings (if wanted I can of course remove that commit from the PR!).
Thanks again!