Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Make gap_size configurable per workspace #7

Closed
Airblader opened this issue Dec 6, 2014 · 3 comments
Closed

Make gap_size configurable per workspace #7

Airblader opened this issue Dec 6, 2014 · 3 comments
Labels
enhancement

Comments

@Airblader
Copy link
Owner

This is a placeholder issue for this topic. Some thought will have to go into how this should work exactly. Also, ideally, this is integrated into the restore layout feature.
@Airblader
Copy link
Owner Author

Idea for commands:

gap_size [<workspace>|current] [plus|minus] <px>

Not specifying a workspace mutates the global value. Note that changing the global value must ensure all currently existing workspaces have their gap size adapted, if necessary.

The config syntax will not change, but set the gap size globally for all workspaces, i.e. it will be the default value for newly created workspaces. The workspace-specific gap size is relative to this one.

A first implementation may only support the optional "current", but not allow specifying a certain workspace.

@Airblader
Copy link
Owner Author

Implemented in feature-gaps-per-workspace for global / current.

Should still be tested with a multi monitor setup and documentation needs to be updated.

@Airblader
Copy link
Owner Author

This has now been merged.

Airblader pushed a commit that referenced this issue Aug 20, 2017
@stapelberg
Bugfix: check bounds before accessing memory
c25bee0 
This fixes the following issue when having an error early in the config file:

==1562==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6220000180ff at pc 0x55c837edb1d3 bp 0x7ffee7534650 sp 0x7ffee7534648
READ of size 1 at 0x6220000180ff thread T0
    #0 0x55c837edb1d2 in start_of_line ../../i3/src/config_parser.c:238
    #1 0x55c837edc96f in parse_config ../../i3/src/config_parser.c:493
    #2 0x55c837edf527 in parse_file ../../i3/src/config_parser.c:1091
    #3 0x55c837ecf14b in parse_configuration ../../i3/src/config.c:65
    #4 0x55c837ed1ef4 in load_configuration ../../i3/src/config.c:230
    #5 0x55c837f0a8d0 in main ../../i3/src/main.c:539
    #6 0x7fb63ae042b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
    #7 0x55c837e95eb9 in _start (/home/michael/i3/build/i3+0x4beb9)

0x6220000180ff is located 1 bytes to the left of 5165-byte region [0x622000018100,0x62200001952d)
allocated by thread T0 here:
    #0 0x7fb63e590cf8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc1cf8)
    #1 0x55c837f59aa6 in smalloc ../../i3/libi3/safewrappers.c:24
    #2 0x55c837edef45 in parse_file ../../i3/src/config_parser.c:1029
    #3 0x55c837ecf14b in parse_configuration ../../i3/src/config.c:65
    #4 0x55c837ed1ef4 in load_configuration ../../i3/src/config.c:230
    #5 0x55c837f0a8d0 in main ../../i3/src/main.c:539
    #6 0x7fb63ae042b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Airblader