Remove the Deprecation warning on generated module files when building
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
changed the title
Deprecation warning on KSP generated files when buildingDeprecation warning on generated module files when building
vinaygaba
approved these changes
Aug 11, 2023
|
I changed the code to fix the lint issue. Could it be approved again? |
|
The CI jobs for UI testing won't start, can we unblock this somehow? |
jmartinesp
force-pushed
the
fix/jmartinesp/remove-deprecation-warning-on-ksp-when-building
branch
from
489ed47
to
0c487fc
Compare
|
I rebased my branch so the |
vinaygaba
approved these changes
Aug 16, 2023
This was referenced Aug 18, 2023
vinaygaba
pushed a commit
that referenced
this pull request
Aug 25, 2023
Following the initial PR #339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just uses the API proposed by the deprecation warning on API 34.
Fixes #335.