Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for disabling YARA rules #98

Merged
merged 2 commits into from
Jan 6, 2018

Conversation

austinbyers
Copy link
Collaborator

to: @ryandeivert
cc: @airbnb/binaryalert-maintainers
size: small

Background

Issue #95 brought some questions about fixing or removing YARA rules which aren't supported (e.g. with those with special modules).

Changes

  • Adds a note to the documentation that we are working on a more expressive rule cloning
  • Adds a section to the documentation on how to disable rules files or individual YARA rules

Testing

  • sphinx-build -W docs/source docs/build and viewing built file locally

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.787% when pulling d2e2ac2 on austin-disable-docs into b319e9f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.787% when pulling d2e2ac2 on austin-disable-docs into b319e9f on master.

Copy link
Contributor

@ryandeivert ryandeivert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@austinbyers austinbyers merged commit f8141d4 into master Jan 6, 2018
@austinbyers austinbyers deleted the austin-disable-docs branch January 6, 2018 02:06
@austinbyers austinbyers added this to the v1.2.0 milestone Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants