Update d8 to latest (#2245) #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Update d8 to version 1.5.20-dev - Also update libraries d8 depends on that need later versions - Pulls in latest changes for D8 now included in android gradle plugin 3.4 which was released yesterday Pull Request resolved: facebook#2245 Reviewed By: styurin Pulled By: styurin fbshipit-source-id: 14acf133f3
|
cc @mmdango |
|
Awesome, thanks for getting this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is necessary to allow jvmTarget=1.8 for kotlin modules, which is now becoming a common practice for kotlin libraries. Without this buck builds would fail with:
CP of:
facebook#2245
Pull Request resolved: Update d8 to latest facebook/buck#2245