Fix the Swift target on arm64 simulator. #32
Conversation
xianwen
force-pushed
the
xianwen--swift-m1-simulator-sdk
branch
from
04e06ac
to
16ab002
Compare
| // For arm64 simulator target, we need to add a "simulator" postfix to differentiate. | ||
| // Otherwise it'll be treated as targeting "ios" and would fail the compilation. | ||
| if (this.flavor.getName().contains("simulator") && this.flavor.getName().contains("arm64")) { | ||
| swiftTargetTriple += "-simulator"; |
There was a problem hiding this comment.
I'm fairly certain that we can append -simulator without checking the architecture. x86_64-apple-ios12.0-simulator is also valid.
There was a problem hiding this comment.
@qyang-nj, we need to check the architecture because the user might be building for "ios device".
There was a problem hiding this comment.
@xianwen Isn't this line this.flavor.getName().contains("simulator") guarantee it's building for simulator?
There was a problem hiding this comment.
@qyang-nj Ah, I see. I misunderstood you the first time.
I was trying to minimize the risk and impact of my changes. Maybe we can remove the check of architecture sometime later, but it's not a high priority issue and I wouldn't feel comfortable removing the checking without doing some extensive testing first.
xianwen
changed the title
Fix the Swift target on arm64 simulator.
@shepting @qyang-nj