Metadata snapshot consumer #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
|
|
||
| class OffsetInfo implements WritableComparable<OffsetInfo> { | ||
| private String topic; |
|
I reformatted after moving to intelliJ, and it addressed the formatting comments you guys had. Other comments: thanks for the comments. |
| oneJsonNode.put("difference", diff); | ||
| jsonData.add(oneJsonNode); | ||
|
|
||
| System.out.println(String.format("Topic: %s OffsetDifference: %d", pk, diff)); |
krishnap
force-pushed
the
metadata-fetcher
branch
from
a444acd
to
38c5bff
Compare
|
Maybe squash all commits into one? Otherwise, looks better. |
krishnap
force-pushed
the
metadata-fetcher
branch
from
38c5bff
to
24f227d
Compare
|
I'd like to schedule this consumer to run today, so i'm going to merge this PR. Feel free to send me more comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brndnmtthws @andykram @wmoss @mrdmnd @jamesmay