Add linting to package.json, do all of the linting. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd commit hook later). Do all of the linting...
| $('#close_shortner').click(function() { | ||
| $('#close_shortner').click(destroyPopover); | ||
|
|
||
| function destroyPopover() { |
There was a problem hiding this comment.
some refactoring was more complicated. e.g., this was to prevent function definitions being too nested in one another.
|
Awesome! let's merge this quick before I get more dirty javascript in there :) |
williaster
added a commit
that referenced
this pull request
Mar 4, 2016
Add linting to package.json, do all of the linting.
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 1, 2018
Add new cherry picks for sqllab hotkeys and lyft colors for graphs :smiling_face_with_horns: @lyft/dp-tools-viz
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
…apache#161) Updates the requirements on [yeoman-test](https://github.com/yeoman/yeoman-test) to permit the latest version. - [Release notes](https://github.com/yeoman/yeoman-test/releases) - [Commits](yeoman/yeoman-test@v1.9.1...v2.0.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…apache#161) Updates the requirements on [yeoman-test](https://github.com/yeoman/yeoman-test) to permit the latest version. - [Release notes](https://github.com/yeoman/yeoman-test/releases) - [Commits](yeoman/yeoman-test@v1.9.1...v2.0.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…apache#161) Updates the requirements on [lint-staged](https://github.com/okonet/lint-staged) to permit the latest version. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v8.0.4...v9.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…apache#161) Updates the requirements on [yeoman-test](https://github.com/yeoman/yeoman-test) to permit the latest version. - [Release notes](https://github.com/yeoman/yeoman-test/releases) - [Commits](yeoman/yeoman-test@v1.9.1...v2.0.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…apache#161) Updates the requirements on [lint-staged](https://github.com/okonet/lint-staged) to permit the latest version. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v8.0.4...v9.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…apache#161) Updates the requirements on [yeoman-test](https://github.com/yeoman/yeoman-test) to permit the latest version. - [Release notes](https://github.com/yeoman/yeoman-test/releases) - [Commits](yeoman/yeoman-test@v1.9.1...v2.0.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…apache#161) Updates the requirements on [lint-staged](https://github.com/okonet/lint-staged) to permit the latest version. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v8.0.4...v9.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…apache#161) Updates the requirements on [yeoman-test](https://github.com/yeoman/yeoman-test) to permit the latest version. - [Release notes](https://github.com/yeoman/yeoman-test/releases) - [Commits](yeoman/yeoman-test@v1.9.1...v2.0.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…apache#161) Updates the requirements on [lint-staged](https://github.com/okonet/lint-staged) to permit the latest version. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v8.0.4...v9.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run
npm run lintto run, will try to add a commit hook later.@mistercrunch