Add instructions to README for avoiding memory leaks #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
approved these changes
Feb 3, 2017
|
Nice text with reasoning and explanations! |
felipecsl
approved these changes
Feb 3, 2017
felipecsl
reviewed
Feb 3, 2017
README.md
Outdated
|
|
||
| The downside to this approach is that the view is immediately cleared, so if you are animating your screen out it will go blank before the animation finishes. A better option that avoids this is to have your LayoutManager recycle its children when the RecyclerView is detached from the window. LinearLayoutManager and GridLayoutManager will do this for you if you enable `setRecycleChildrenOnDetach(true)`. | ||
|
|
||
| To automatically apply this you may wish to create a base adapter in your project that extends EpoxyAdapter. |
There was a problem hiding this comment.
nit: you may want to backtick EpoxyAdapter, LinearLayoutManager and others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#97
@felipecsl @seanabraham @gpeal
Hopefully this is clear enough so people don't fall prey to these leaks.