Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing loadStateFlow to PagingDataEpoxyController #1209

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Add missing loadStateFlow to PagingDataEpoxyController #1209

merged 4 commits into from
Aug 27, 2021

Conversation

ggajews
Copy link
Contributor

@ggajews ggajews commented Jul 2, 2021

Based on PagingDataAdapter from Paging3 lib

elihart
elihart reviewed Jul 17, 2021
View reviewed changes
Copy link
Contributor

@elihart elihart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @ggajews . Only request is to remove the backing fields

epoxy-paging3/src/main/java/com/airbnb/epoxy/paging3/PagedDataModelCache.kt Outdated Show resolved Hide resolved
epoxy-paging3/src/main/java/com/airbnb/epoxy/paging3/PagingDataEpoxyController.kt
@@ -30,7 +30,6 @@ import kotlinx.coroutines.ObsoleteCoroutinesApi
*
* @param T The type of the item in the [PagingData].
*/
@ObsoleteCoroutinesApi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up

epoxy-paging3/src/main/java/com/airbnb/epoxy/paging3/PagingDataEpoxyController.kt Outdated Show resolved Hide resolved
@ggajews @elihart
Do not use backing fields
52e46ef 
Co-authored-by: Eli Hart <konakid@gmail.com>
@ggajews ggajews requested a review from elihart July 19, 2021 07:11
elihart
elihart approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@elihart elihart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! will put out another release next week

@elihart elihart merged commit 683fb63 into airbnb:master Aug 27, 2021
@m-sabeeh m-sabeeh mentioned this pull request Sep 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elihart elihart elihart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggajews @elihart