Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#254 Inherit annotations in epoxy model generated classes #255

Merged
merged 1 commit into from
Aug 7, 2017
Merged

#254 Inherit annotations in epoxy model generated classes #255

merged 1 commit into from
Aug 7, 2017

Conversation

geralt-encore
Copy link
Contributor

elihart
elihart approved these changes Aug 7, 2017
View reviewed changes
Copy link
Contributor

@elihart elihart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! that was quick :P

Thanks a lot :)

btw, I'm planning to add a few annotation processor features soon and will do some more kotlin updates then.

@elihart elihart merged commit dcd49bc into airbnb:master Aug 7, 2017
@geralt-encore
Copy link
Contributor Author

Cool! I was trying to convert all AttributeModel model to Kotlin, but it turned out to be pretty hard to do in a Kotlin-way so I gave up for now =(

@elihart
Copy link
Contributor

elihart commented Aug 7, 2017

Yeah, those classes are unfortunately a mess and overly complicated. they need a refactor, thanks for trying though :)

@geralt-encore
Copy link
Contributor Author

ViewAttributeInfo was the most complex one for me. Still have close to zero ideas what's going on in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elihart elihart elihart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geralt-encore @elihart