Block item click callback during item layout. #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a RecyclerView.NO_POSITION != viewHolder.getAdapterPosition() check inside of the click listener wrapper ensures we do not call the click listener when the item is going through a layout. There was a need to make a change to the ControllerLifecycleHelper to ensure that click still passed as the adapter was always supplying `NO_POSITION` for unit tests. The simplest way to get the basic functionality was to spy the viewHolder, and stub this method. ISSUE airbnb#293
niccorder
commented
Oct 2, 2017
| ); | ||
|
|
||
| // The simplest way to inject the position for testing. | ||
| when(viewHolder.getAdapterPosition()).thenReturn(position); |
There was a problem hiding this comment.
Although I feel this isn't ideal, I found it to be the least obtrusive. Would love feedback if anyone has a more proper idea on how to fix.
There was a problem hiding this comment.
This seems reasonable, thanks for fixing the tests too 👍
elihart
approved these changes
Oct 3, 2017
| ); | ||
|
|
||
| // The simplest way to inject the position for testing. | ||
| when(viewHolder.getAdapterPosition()).thenReturn(position); |
There was a problem hiding this comment.
This seems reasonable, thanks for fixing the tests too 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
RecyclerView.NO_POSITION != viewHolder.getAdapterPosition()check inside of the click listener wrapper ensures we do not call the
click listener when the item is going through a layout.
There was a need to make a change to theControllerLifecycleHelper
to ensure that click still passed as the adapter was always supplying
NO_POSITIONfor unit tests. The simplest way to get the basicfunctionality was to spy the
ViewHolder, and stub this method.ISSUE #293