Blacklist setLifecycleOwner method in databinding field parsing, fixes #412 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngsilverman
commented
Apr 8, 2018
| setMainThreadExecutor(UiThreadExecutor) | ||
| setBackgroundThreadExecutor(AsyncTask.THREAD_POOL_EXECUTOR) | ||
| setNotifyExecutor(UiThreadExecutor) | ||
| setFetchExecutor(AsyncTask.THREAD_POOL_EXECUTOR) |
There was a problem hiding this comment.
These methods were renamed, see https://developer.android.com/topic/libraries/architecture/release-notes.html#paging.
elihart
reviewed
Apr 8, 2018
| val dataBindingClassElement: Element? | ||
| get() = getElementByName(dataBindingClassName, elementUtils, typeUtils) | ||
| private val dataBindingClassElement: TypeElement? | ||
| get() = getElementByName(dataBindingClassName, elementUtils, typeUtils) as TypeElement? |
There was a problem hiding this comment.
should this be as? TypeElement instead?
There was a problem hiding this comment.
@elihart I'm thinking: if getElementByName doesn't return a TypeElement or null then something unexpected is happening since we're passing it a ClassName. In fact maybe it would make more sense to change the return type of getElementByName(ClassName name, Elements elements, Types types). Thoughts?
There was a problem hiding this comment.
I changed the return type to TypeElement and everything still builds and all tests are passing so seems reasonable.
…#412 ViewDataBinding subclasses can now override the setLifecycleOwner method causing it to be erroneously detected as a model property.
ngsilverman
force-pushed
the
nsilverman-databinding-method-blacklist
branch
from
d0b0dc5
to
c8c51ff
Compare
This was referenced Apr 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewDataBinding subclasses can now override the setLifecycleOwner method causing it to be erroneously detected as a model field. This fix introduces a field blacklist to ignore this method and possibly others in the future.
To reproduce the issue and create a test for it I had to update the Android plugin version which forced me to also update Gradle, the target SDK, and the paging library. I removed the buildToolsVersion declarations to remove a warning (the build tools version is now provided by the Android plugin from what I understand).