Fallback to kotlin.Function + noinline #501
Conversation
Signed-off-by: shaishavgandhi05 <shaishgandhi@gmail.com>
There was a problem hiding this comment.
Thanks for putting this up so quickly! it looks right, unfortunatley our testing tools don't support kotlin generated code, only java, so I don't have tests for this.
what I do though is add a class to the kotlinsample module and our checks make sure that that compiles
| paramName, | ||
| type.toKPoet(nullable), | ||
| *modifiers.toKModifier().toTypedArray() | ||
| ).build() | ||
| ) |
| @@ -78,6 +79,10 @@ private fun JavaClassName.getPackageNameInKotlin(): String { | |||
| return packageName() | |||
| } | |||
|
|
|||
| fun isLambda(type: JavaTypeName): Boolean { | |||
There was a problem hiding this comment.
seems that this should check the kotlin package too, since any other random class could technically contain this
There was a problem hiding this comment.
Added a check to see if it also contains the keyword kotlin.
| "Collection", | ||
| "List", | ||
| "Map", | ||
| "Set", | ||
| "Iterable" -> kotlinCollectionsPkg | ||
| "String" -> kotlinPkg | ||
| "String", "Function1" -> kotlinPkg |
There was a problem hiding this comment.
is it necessary to check Function1 since the isLambda check is already done?
There was a problem hiding this comment.
Oops that's my bad. Leftover code from when i was experimenting.
|
Thanks! Will add this sample to I've struggled with Kotlin code generation testing also since we don't have an equivalent to the Google compile testing library for Kotlin. I usually fallback to adding sample classes in the What do you think? |
|
@shaishavgandhi05 that makes sense, the test directory would be great. Thanks a lot! Hopefully we will have a kotlin compile testing library someday :P |
* Add test folder in kotlinsample Signed-off-by: shaishavgandhi05 <shaishgandhi@gmail.com>
|
Anything blocking here? Have addressed the PR comments. |
|
Nothing blocking, looks great, thanks! |
Initial pass for fixing issue in #500 .
I would love to add some tests for this, but I couldn't find any tests for Kotlin extension that are generated.
#500 has relevant details on the exact thing causing the error.