Refactor stopPropagation to fix #198
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malash
force-pushed
the
refactor-stopPropagation
branch
from
3fb8c31
to
13a2c02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed #198
Previously, GojiJS used
e.target.datasetto detect whether an event had been stopped or not. However, this approach failed to work when crossing custom component such asSubtreeor wrapped components. To improve stability, I have refactored the implementation ofstopPropagationusing the instance tree ( VDOM tree ).When
stopPropagationis called on an element, GojiJS marks itself and its ancestors as stopped, and they will no longer accept events with the sametypeandtimeStamp. Throughout this process, we assume that events with the same typeandtimeStamp` are dispatched from the same source.